[PATCH] drm/amdgpu: Remove ununsed variable that holds a return value

Carlos Eduardo Gallo Filho gcarlos at disroot.org
Sat Mar 25 17:20:51 UTC 2023


Compiling amdgpu with W=1 get that unused-but-set-variable warning.

drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’:
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable]
 1099 |         int r;
      |             ^

That variable is used to hold the return value of amdgpu_bo_create_kernel()
function call.

Remove r to fix the warning.
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
index 82e27bd4f038..a45c31717ae3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
@@ -1096,14 +1096,12 @@ uint32_t amdgpu_mes_get_aggregated_doorbell_index(struct amdgpu_device *adev,
 int amdgpu_mes_ctx_alloc_meta_data(struct amdgpu_device *adev,
 				   struct amdgpu_mes_ctx_data *ctx_data)
 {
-	int r;
-
-	r = amdgpu_bo_create_kernel(adev,
-			    sizeof(struct amdgpu_mes_ctx_meta_data),
-			    PAGE_SIZE, AMDGPU_GEM_DOMAIN_GTT,
-			    &ctx_data->meta_data_obj,
-			    &ctx_data->meta_data_mc_addr,
-			    &ctx_data->meta_data_ptr);
+	amdgpu_bo_create_kernel(adev,
+				sizeof(struct amdgpu_mes_ctx_meta_data),
+				PAGE_SIZE, AMDGPU_GEM_DOMAIN_GTT,
+				&ctx_data->meta_data_obj,
+				&ctx_data->meta_data_mc_addr,
+				&ctx_data->meta_data_ptr);
 	if (!ctx_data->meta_data_obj)
 		return -ENOMEM;
 
-- 
2.39.2



More information about the amd-gfx mailing list