[PATCH 3/3] drm/amdgpu: enable sysfs node vclk1 and dclk1 for NV3X

Quan, Evan Evan.Quan at amd.com
Thu Mar 30 03:58:43 UTC 2023


[AMD Official Use Only - General]

Please update the patch headers for the series with the prefix "drm/amd/pm" to align with other power changes.
With that fixed, the series is reviewed-by: Evan Quan <evan.quan at amd.com>

Evan
> -----Original Message-----
> From: Tong Liu01 <Tong.Liu01 at amd.com>
> Sent: Thursday, March 30, 2023 11:15 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Quan, Evan <Evan.Quan at amd.com>; Chen, Horace
> <Horace.Chen at amd.com>; Tuikov, Luben <Luben.Tuikov at amd.com>;
> Koenig, Christian <Christian.Koenig at amd.com>; Deucher, Alexander
> <Alexander.Deucher at amd.com>; Xiao, Jack <Jack.Xiao at amd.com>; Zhang,
> Hawking <Hawking.Zhang at amd.com>; Liu, Monk <Monk.Liu at amd.com>; Xu,
> Feifei <Feifei.Xu at amd.com>; Wang, Yang(Kevin)
> <KevinYang.Wang at amd.com>; Liu01, Tong (Esther) <Tong.Liu01 at amd.com>
> Subject: [PATCH 3/3] drm/amdgpu: enable sysfs node vclk1 and dclk1 for
> NV3X
> 
> Enable node pp_dpm_vclk1 and pp_dpm_dclk1 for gc11.0.2 and gc11.0.3
> 
> Signed-off-by: Tong Liu01 <Tong.Liu01 at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index d8b9c6136fc0..e011041e3ec6 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2125,7 +2125,9 @@ static int default_attr_update(struct
> amdgpu_device *adev, struct amdgpu_device_
>  			*states = ATTR_STATE_UNSUPPORTED;
>  	} else if (DEVICE_ATTR_IS(pp_dpm_vclk1)) {
>  		if (!((gc_ver == IP_VERSION(10, 3, 1) ||
> -			   gc_ver == IP_VERSION(10, 3, 0)) && adev-
> >vcn.num_vcn_inst >= 2))
> +			   gc_ver == IP_VERSION(10, 3, 0) ||
> +			   gc_ver == IP_VERSION(11, 0, 2) ||
> +			   gc_ver == IP_VERSION(11, 0, 3)) && adev-
> >vcn.num_vcn_inst >= 2))
>  			*states = ATTR_STATE_UNSUPPORTED;
>  	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
>  		if (!(gc_ver == IP_VERSION(10, 3, 1) || @@ -2137,7 +2139,9
> @@ static int default_attr_update(struct amdgpu_device *adev, struct
> amdgpu_device_
>  			*states = ATTR_STATE_UNSUPPORTED;
>  	} else if (DEVICE_ATTR_IS(pp_dpm_dclk1)) {
>  		if (!((gc_ver == IP_VERSION(10, 3, 1) ||
> -			   gc_ver == IP_VERSION(10, 3, 0)) && adev-
> >vcn.num_vcn_inst >= 2))
> +			   gc_ver == IP_VERSION(10, 3, 0) ||
> +			   gc_ver == IP_VERSION(11, 0, 2) ||
> +			   gc_ver == IP_VERSION(11, 0, 3)) && adev-
> >vcn.num_vcn_inst >= 2))
>  			*states = ATTR_STATE_UNSUPPORTED;
>  	} else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {
>  		if (amdgpu_dpm_get_power_profile_mode(adev, NULL) ==
> -EOPNOTSUPP)
> --
> 2.34.1


More information about the amd-gfx mailing list