[PATCH 2/2] drm/amdgpu: retire set_vga_state for some ASIC

Gao, Likun Likun.Gao at amd.com
Fri May 19 11:17:03 UTC 2023


[AMD Official Use Only - General]

From: Likun Gao <Likun.Gao at amd.com>

set_vga_state operation only allowed on SI generation ASIC, retire the realted function on those ASIC which did not do anything.

Signed-off-by: Likun Gao <Likun.Gao at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/nv.c    | 6 ------
 drivers/gpu/drm/amd/amdgpu/soc15.c | 8 --------  drivers/gpu/drm/amd/amdgpu/soc21.c | 6 ------
 drivers/gpu/drm/amd/amdgpu/vi.c    | 6 ------
 4 files changed, 26 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index a5f76c9538c4..51523b27a186 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -341,11 +341,6 @@ void nv_grbm_select(struct amdgpu_device *adev,
        WREG32_SOC15(GC, 0, mmGRBM_GFX_CNTL, grbm_gfx_cntl);  }

-static void nv_vga_set_state(struct amdgpu_device *adev, bool state) -{
-       /* todo */
-}
-
 static bool nv_read_disabled_bios(struct amdgpu_device *adev)  {
        /* todo */
@@ -654,7 +649,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =
        .read_register = &nv_read_register,
        .reset = &nv_asic_reset,
        .reset_method = &nv_asic_reset_method,
-       .set_vga_state = &nv_vga_set_state,
        .get_xclk = &nv_get_xclk,
        .set_uvd_clocks = &nv_set_uvd_clocks,
        .set_vce_clocks = &nv_set_vce_clocks,
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 122ba1a505c3..135440b5afe9 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -346,11 +346,6 @@ void soc15_grbm_select(struct amdgpu_device *adev,
        WREG32_SOC15_RLC_SHADOW(GC, xcc_id, mmGRBM_GFX_CNTL, grbm_gfx_cntl);  }

-static void soc15_vga_set_state(struct amdgpu_device *adev, bool state) -{
-       /* todo */
-}
-
 static bool soc15_read_disabled_bios(struct amdgpu_device *adev)  {
        /* todo */
@@ -849,7 +844,6 @@ static const struct amdgpu_asic_funcs soc15_asic_funcs =
        .read_register = &soc15_read_register,
        .reset = &soc15_asic_reset,
        .reset_method = &soc15_asic_reset_method,
-       .set_vga_state = &soc15_vga_set_state,
        .get_xclk = &soc15_get_xclk,
        .set_uvd_clocks = &soc15_set_uvd_clocks,
        .set_vce_clocks = &soc15_set_vce_clocks, @@ -871,7 +865,6 @@ static const struct amdgpu_asic_funcs vega20_asic_funcs =
        .read_register = &soc15_read_register,
        .reset = &soc15_asic_reset,
        .reset_method = &soc15_asic_reset_method,
-       .set_vga_state = &soc15_vga_set_state,
        .get_xclk = &soc15_get_xclk,
        .set_uvd_clocks = &soc15_set_uvd_clocks,
        .set_vce_clocks = &soc15_set_vce_clocks, @@ -893,7 +886,6 @@ static const struct amdgpu_asic_funcs aqua_vanjaram_asic_funcs =
        .read_register = &soc15_read_register,
        .reset = &soc15_asic_reset,
        .reset_method = &soc15_asic_reset_method,
-       .set_vga_state = &soc15_vga_set_state,
        .get_xclk = &soc15_get_xclk,
        .set_uvd_clocks = &soc15_set_uvd_clocks,
        .set_vce_clocks = &soc15_set_vce_clocks, diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c
index 6bff936a6e55..e5e5d68a4d70 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc21.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc21.c
@@ -248,11 +248,6 @@ void soc21_grbm_select(struct amdgpu_device *adev,
        WREG32_SOC15(GC, 0, regGRBM_GFX_CNTL, grbm_gfx_cntl);  }

-static void soc21_vga_set_state(struct amdgpu_device *adev, bool state) -{
-       /* todo */
-}
-
 static bool soc21_read_disabled_bios(struct amdgpu_device *adev)  {
        /* todo */
@@ -559,7 +554,6 @@ static const struct amdgpu_asic_funcs soc21_asic_funcs =
        .read_register = &soc21_read_register,
        .reset = &soc21_asic_reset,
        .reset_method = &soc21_asic_reset_method,
-       .set_vga_state = &soc21_vga_set_state,
        .get_xclk = &soc21_get_xclk,
        .set_uvd_clocks = &soc21_set_uvd_clocks,
        .set_vce_clocks = &soc21_set_vce_clocks, diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index 8e70581960fb..770f2d7a371f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -580,11 +580,6 @@ void vi_srbm_select(struct amdgpu_device *adev,
        WREG32(mmSRBM_GFX_CNTL, srbm_gfx_cntl);  }

-static void vi_vga_set_state(struct amdgpu_device *adev, bool state) -{
-       /* todo */
-}
-
 static bool vi_read_disabled_bios(struct amdgpu_device *adev)  {
        u32 bus_cntl;
@@ -1435,7 +1430,6 @@ static const struct amdgpu_asic_funcs vi_asic_funcs =
        .read_register = &vi_read_register,
        .reset = &vi_asic_reset,
        .reset_method = &vi_asic_reset_method,
-       .set_vga_state = &vi_vga_set_state,
        .get_xclk = &vi_get_xclk,
        .set_uvd_clocks = &vi_set_uvd_clocks,
        .set_vce_clocks = &vi_set_vce_clocks,
--
2.34.1



More information about the amd-gfx mailing list