[PATCH] drm/amd/pm: add missing NotifyPowerSource message mapping for SMU13.0.7

[Quan, Evan]

[Public]

> -----Original Message-----
> From: Chen, Guchun <Guchun.Chen at amd.com>
> Sent: Friday, May 19, 2023 8:04 PM
> To: Quan, Evan <Evan.Quan at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Quan, Evan
> <Evan.Quan at amd.com>
> Subject: RE: [PATCH] drm/amd/pm: add missing NotifyPowerSource message
> mapping for SMU13.0.7
>
> [Public]
>
> Looks it's better to add a Fixes tag like Fixes: 4dd9b5392c57 ("drm/amd/pm:
> fix possible power mode mismatch between driver and PMFW"), if I
> understand it correctly.
Yes, will add that in V2.

Evan
>
> Regards,
> Guchun
>
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > Evan Quan
> > Sent: Friday, May 19, 2023 3:53 PM
> > To: amd-gfx at lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Quan, Evan
> > <Evan.Quan at amd.com>
> > Subject: [PATCH] drm/amd/pm: add missing NotifyPowerSource message
> > mapping for SMU13.0.7
> >
> > Otherwise, the power source switching will fail due to message unavailable.
> >
> > Signed-off-by: Evan Quan <evan.quan at amd.com>
> > ---
> >  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > index 1b6116cf8b4c..cf6827179fd1 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> > @@ -125,6 +125,7 @@ static struct cmn2asic_msg_mapping
> > smu_v13_0_7_message_map[SMU_MSG_MAX_COUNT] =
> >       MSG_MAP(ArmD3,                          PPSMC_MSG_ArmD3,
> > 0),
> >       MSG_MAP(AllowGpo,                       PPSMC_MSG_SetGpoAllow,
> > 0),
> >       MSG_MAP(GetPptLimit,
> >       PPSMC_MSG_GetPptLimit,                 0),
> > +     MSG_MAP(NotifyPowerSource,
> >       PPSMC_MSG_NotifyPowerSource,           0),
> >  };
> >
> >  static struct cmn2asic_mapping smu_v13_0_7_clk_map[SMU_CLK_COUNT]
> = {
> > --
> > 2.34.1
>