[PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all

Christian König christian.koenig at amd.com
Thu May 25 13:52:17 UTC 2023


Am 25.05.23 um 11:28 schrieb Guchun Chen:
> This can clean up all irq warnings because of unbalanced
> amdgpu_irq_get/put when unplugging/unbind device, and leave
> irq count decrease in each ip fini function.
>
> Signed-off-by: Guchun Chen <guchun.chen at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 00f2106c17b9..f90920fbd340 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -140,7 +140,6 @@ void amdgpu_irq_disable_all(struct amdgpu_device *adev)
>   				continue;
>   
>   			for (k = 0; k < src->num_types; ++k) {
> -				atomic_set(&src->enabled_types[k], 0);
>   				r = src->funcs->set(adev, src, k,
>   						    AMDGPU_IRQ_STATE_DISABLE);
>   				if (r)



More information about the amd-gfx mailing list