[PATCH] drm/amdgpu: Fix create_dmamap_sg_bo kdoc warnings

Felix Kuehling felix.kuehling at amd.com
Mon May 29 18:59:44 UTC 2023


On 2023-05-27 12:59, Srinivasan Shanmugam wrote:
> Fix the following gcc with W=1:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:292: warning: Cannot understand  * @create_dmamap_sg_bo: Creates a amdgpu_bo object to reflect information
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index fa4057da0d7f..4540d0964801 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -288,7 +288,7 @@ void amdgpu_amdkfd_release_notify(struct amdgpu_bo *bo)
>   	kfree(bo->kfd_bo);
>   }
>   
> -/**
> +/*
>    * @create_dmamap_sg_bo: Creates a amdgpu_bo object to reflect information

This was obviously meant to be a kdoc comment that is just badly 
formatted. Can you fix the format instead to make it valid?

Thanks,
   Felix


>    * about USERPTR or DOOREBELL or MMIO BO.
>    * @adev: Device for which dmamap BO is being created


More information about the amd-gfx mailing list