[PATCH] drm/amdgpu: Fix up missing kdoc parameter 'inst' in get_wave_count() & kgd_gfx_v9_get_cu_occupancy()

[Felix Kuehling]

Am 2023-05-30 um 08:48 schrieb Srinivasan Shanmugam:
> Fix these warnings by adding 'inst' arguments to kdocs.
>
> gcc with W=1
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:692: warning: Function parameter or member 'inst' not described in 'get_wave_count'
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:763: warning: Function parameter or member 'inst' not described in 'kgd_gfx_v9_get_cu_occupancy'
>
> Cc: Felix Kuehling <Felix.Kuehling at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
> index 9fa9aab22fe9..34bf030f3137 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
> @@ -685,7 +685,8 @@ static void unlock_spi_csq_mutexes(struct amdgpu_device *adev)
>    * @queue_idx: Index of queue in the queue-map bit-field
>    * @wave_cnt: Output parameter updated with number of waves in flight
>    * @vmid: Output parameter updated with VMID of queue whose wave count
> - * is being collected
> + *        is being collected
> + * @inst: xcc's instance number on a multi-XCC setup
>    */
>   static void get_wave_count(struct amdgpu_device *adev, int queue_idx,
>   		int *wave_cnt, int *vmid, uint32_t inst)
> @@ -721,9 +722,10 @@ static void get_wave_count(struct amdgpu_device *adev, int queue_idx,
>    * @adev: Handle of device from which to get number of waves in flight
>    * @pasid: Identifies the process for which this query call is invoked
>    * @pasid_wave_cnt: Output parameter updated with number of waves in flight that
> - * belong to process with given pasid
> + *                  belong to process with given pasid
>    * @max_waves_per_cu: Output parameter updated with maximum number of waves
> - * possible per Compute Unit
> + *                    possible per Compute Unit
> + * @inst: xcc's instance number on a multi-XCC setup
>    *
>    * Note: It's possible that the device has too many queues (oversubscription)
>    * in which case a VMID could be remapped to a different PASID. This could lead