[PATCH] drm/amdgpu: Fix up missing parameters kdoc in svm_migrate_vma_to_ram

Felix Kuehling felix.kuehling at amd.com
Tue May 30 15:51:22 UTC 2023


Am 2023-05-30 um 00:54 schrieb Srinivasan Shanmugam:
> Fix these warnings by adding & deleting the deviant arguments.
>
> gcc with W=1
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:671: warning: Function parameter or member 'node' not described in 'svm_migrate_vma_to_ram'
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:671: warning: Function parameter or member 'trigger' not described in 'svm_migrate_vma_to_ram'
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:671: warning: Function parameter or member 'fault_page' not described in 'svm_migrate_vma_to_ram'
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:671: warning: Excess function parameter 'adev' description in 'svm_migrate_vma_to_ram'
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:771: warning: Function parameter or member 'fault_page' not described in 'svm_migrate_vram_to_ram'
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 35cf6558cf1b..58d95fb99595 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -651,11 +651,13 @@ svm_migrate_copy_to_ram(struct amdgpu_device *adev, struct svm_range *prange,
>   /**
>    * svm_migrate_vma_to_ram - migrate range inside one vma from device to system
>    *
> - * @adev: amdgpu device to migrate from
>    * @prange: svm range structure
>    * @vma: vm_area_struct that range [start, end] belongs to
>    * @start: range start virtual address in pages
>    * @end: range end virtual address in pages
> + * @node: kfd node device to migrate from
> + * @trigger: reason of migration
> + * @fault_page: is from vmf->page, svm_migrate_to_ram(), this is CPU page fault callback
>    *
>    * Context: Process context, caller hold mmap read lock, prange->migrate_mutex
>    *
> @@ -760,6 +762,7 @@ svm_migrate_vma_to_ram(struct kfd_node *node, struct svm_range *prange,
>    * @prange: range structure
>    * @mm: process mm, use current->mm if NULL
>    * @trigger: reason of migration
> + * @fault_page: is from vmf->page, svm_migrate_to_ram(), this is CPU page fault callback
>    *
>    * Context: Process context, caller hold mmap read lock, prange->migrate_mutex
>    *


More information about the amd-gfx mailing list