[PATCH] drm/amdgpu: Fix missing parameter desc for 'xcp_id' in amdgpu_amdkfd_reserve_mem_limit

Felix Kuehling felix.kuehling at amd.com
Tue May 30 16:36:25 UTC 2023


Am 2023-05-29 um 10:56 schrieb Srinivasan Shanmugam:
> Fix these warnings by adding 'xcp_id' argument.
>
> gcc with W=1
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:160: warning: Function parameter or member 'xcp_id' not described in 'amdgpu_amdkfd_reserve_mem_limit'
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index fa4057da0d7f..cd5d7a39ad0c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -152,8 +152,11 @@ void amdgpu_amdkfd_reserve_system_mem(uint64_t size)
>    * @size: Size of buffer, in bytes, encapsulated by B0. This should be
>    * equivalent to amdgpu_bo_size(BO)
>    * @alloc_flag: Flag used in allocating a BO as noted above
> + * @xcp_id: xcp_id is used to get xcp from xcp manager, one xcp is
> + * managed as one compute node in driver for app
>    *
> - * Return: returns -ENOMEM in case of error, ZERO otherwise
> + * Return:
> + *	returns -ENOMEM in case of error, ZERO otherwise
>    */
>   int amdgpu_amdkfd_reserve_mem_limit(struct amdgpu_device *adev,
>   		uint64_t size, u32 alloc_flag, int8_t xcp_id)


More information about the amd-gfx mailing list