[PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

[Christian König]

Am 31.05.23 um 08:20 schrieb Chen, Guchun:
> [Public]
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Ma
>> Jun
>> Sent: Wednesday, May 31, 2023 1:31 PM
>> To: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Koenig,
>> Christian <Christian.Koenig at amd.com>
>> Cc: Ma, Jun <Jun.Ma2 at amd.com>
>> Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields
>>
>> Remove redundant assignment code for ttm->caching as it's overwritten
>>
>> just a few lines later.
> Please drop the blank line in above message. With it fixed, the patch is: Reviewed-by: Guchun Chen <guchun.chen at amd.com>

Seconded, I'm going to pick that patch up and submit it to drm-misc-next 
with the commit message fixed.

Regards,
Christian.

>
> Regards,
> Guchun
>
>> v2:
>>   - Update the commit message.
>>
>> Signed-off-by: Ma Jun <Jun.Ma2 at amd.com>
>> ---
>>   drivers/gpu/drm/ttm/ttm_tt.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
>> index 02b812dacc5d..45a44544b656 100644
>> --- a/drivers/gpu/drm/ttm/ttm_tt.c
>> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
>> @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm,
>>                               unsigned long extra_pages)
>>   {
>>        ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) +
>> extra_pages;
>> -     ttm->caching = ttm_cached;
>>        ttm->page_flags = page_flags;
>>        ttm->dma_address = NULL;
>>        ttm->swap_storage = NULL;
>> --
>> 2.34.1