[PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.
kernel test robot
lkp at intel.com
Wed Nov 1 01:18:36 UTC 2023
Hi Tatsuyuki,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes linus/master v6.6]
[cannot apply to drm/drm-next drm-intel/for-linux-next drm-tip/drm-tip next-20231031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tatsuyuki-Ishi/drm-amdgpu-Don-t-implicit-sync-PRT-maps/20231031-224530
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20231031134059.171277-4-ishitatsuyuki%40gmail.com
patch subject: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.
config: arc-randconfig-001-20231101 (https://download.01.org/0day-ci/archive/20231101/202311010948.G6I55pTu-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311010948.G6I55pTu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311010948.G6I55pTu-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:608: warning: Excess function parameter 'bo_va' description in 'amdgpu_gem_va_update_vm'
>> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:608: warning: Excess function parameter 'operation' description in 'amdgpu_gem_va_update_vm'
vim +608 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
d38ceaf99ed015f Alex Deucher 2015-04-20 594
d38ceaf99ed015f Alex Deucher 2015-04-20 595 /**
d38ceaf99ed015f Alex Deucher 2015-04-20 596 * amdgpu_gem_va_update_vm -update the bo_va in its VM
d38ceaf99ed015f Alex Deucher 2015-04-20 597 *
d38ceaf99ed015f Alex Deucher 2015-04-20 598 * @adev: amdgpu_device pointer
dc54d3d1744d23e Christian König 2017-03-13 599 * @vm: vm to update
d38ceaf99ed015f Alex Deucher 2015-04-20 600 * @bo_va: bo_va to update
dc54d3d1744d23e Christian König 2017-03-13 601 * @operation: map, unmap or clear
d38ceaf99ed015f Alex Deucher 2015-04-20 602 *
2ffdaafb5d5f37b Christian König 2017-01-27 603 * Update the bo_va directly after setting its address. Errors are not
d38ceaf99ed015f Alex Deucher 2015-04-20 604 * vital here, so they are not reported back to userspace.
d38ceaf99ed015f Alex Deucher 2015-04-20 605 */
d38ceaf99ed015f Alex Deucher 2015-04-20 606 static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 607 struct amdgpu_vm *vm)
d38ceaf99ed015f Alex Deucher 2015-04-20 @608 {
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 609 struct amdgpu_bo_va *bo_va;
3f3333f8a0e90ac Christian König 2017-08-03 610 int r;
d38ceaf99ed015f Alex Deucher 2015-04-20 611
3f3333f8a0e90ac Christian König 2017-08-03 612 if (!amdgpu_vm_ready(vm))
3f3333f8a0e90ac Christian König 2017-08-03 613 return;
e410b5cbabe70b1 Chunming Zhou 2015-12-07 614
f34678187a33970 Nicolai Hähnle 2017-03-23 615 r = amdgpu_vm_clear_freed(adev, vm, NULL);
d38ceaf99ed015f Alex Deucher 2015-04-20 616 if (r)
2ffdaafb5d5f37b Christian König 2017-01-27 617 goto error;
194a33643b1161f monk.liu 2015-07-22 618
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 619 spin_lock(&vm->status_lock);
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 620 while (!list_empty(&vm->dirty)) {
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 621 bo_va = list_first_entry(&vm->dirty, struct amdgpu_bo_va,
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 622 base.vm_status);
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 623 spin_unlock(&vm->status_lock);
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 624
8f8cc3fb43508a2 Christian König 2022-03-17 625 r = amdgpu_vm_bo_update(adev, bo_va, false);
0abc6878fc2d699 Christian König 2017-09-01 626 if (r)
0abc6878fc2d699 Christian König 2017-09-01 627 goto error;
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 628 spin_lock(&vm->status_lock);
93bab704c1513f8 Gustavo A. R. Silva 2018-02-14 629 }
ddf1ffe56ab385a Tatsuyuki Ishi 2023-10-31 630 spin_unlock(&vm->status_lock);
93bab704c1513f8 Gustavo A. R. Silva 2018-02-14 631
807e2994092c0bd Christian König 2019-03-14 632 r = amdgpu_vm_update_pdes(adev, vm, false);
0abc6878fc2d699 Christian König 2017-09-01 633
2ffdaafb5d5f37b Christian König 2017-01-27 634 error:
68fdd3df79ee4bf Christian König 2015-06-16 635 if (r && r != -ERESTARTSYS)
d38ceaf99ed015f Alex Deucher 2015-04-20 636 DRM_ERROR("Couldn't update BO_VA (%d)\n", r);
d38ceaf99ed015f Alex Deucher 2015-04-20 637 }
d38ceaf99ed015f Alex Deucher 2015-04-20 638
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the amd-gfx
mailing list