[PATCH] drm/amdgpu: Don't warn for unsupported set_xgmi_plpd_mode

[Yang, Stanley]

[AMD Official Use Only - General]

Reviewed-by: Stanley.Yang <Stanley.Yang at amd.com>

Regards,
Stanley
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Tao
> Zhou
> Sent: Tuesday, October 31, 2023 3:08 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Lazar, Lijo <Lijo.Lazar at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>
> Subject: [PATCH] drm/amdgpu: Don't warn for unsupported
> set_xgmi_plpd_mode
>
> set_xgmi_plpd_mode may be unsupported and this isn't error, no need to
> print warning for it.
>
> Suggested-by: lijo.lazar at amd.com
> Signed-off-by: Tao Zhou <tao.zhou1 at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 0533f873001b..c9b09bddbcdc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -1138,7 +1138,8 @@ static int amdgpu_ras_error_inject_xgmi(struct
> amdgpu_device *adev,
>       if (amdgpu_dpm_set_df_cstate(adev, DF_CSTATE_DISALLOW))
>               dev_warn(adev->dev, "Failed to disallow df cstate");
>
> -     if (amdgpu_dpm_set_xgmi_plpd_mode(adev,
> XGMI_PLPD_DISALLOW))
> +     ret = amdgpu_dpm_set_xgmi_plpd_mode(adev,
> XGMI_PLPD_DISALLOW);
> +     if (ret && ret != -EOPNOTSUPP)
>               dev_warn(adev->dev, "Failed to disallow XGMI power down");
>
>       ret = psp_ras_trigger_error(&adev->psp, block_info, instance_mask);
> @@ -1146,7 +1147,8 @@ static int amdgpu_ras_error_inject_xgmi(struct
> amdgpu_device *adev,
>       if (amdgpu_ras_intr_triggered())
>               return ret;
>
> -     if (amdgpu_dpm_set_xgmi_plpd_mode(adev, XGMI_PLPD_DEFAULT))
> +     ret = amdgpu_dpm_set_xgmi_plpd_mode(adev,
> XGMI_PLPD_DEFAULT);
> +     if (ret && ret != -EOPNOTSUPP)
>               dev_warn(adev->dev, "Failed to allow XGMI power down");
>
>       if (amdgpu_dpm_set_df_cstate(adev, DF_CSTATE_ALLOW))
> --
> 2.35.1