[PATCH 2/2] drm/amd/display: Fix stack size issue on DML2

Hamza Mahfooz hamza.mahfooz at amd.com
Mon Nov 6 12:13:17 UTC 2023


On 11/5/23 12:55, Guenter Roeck wrote:
> On Mon, Oct 16, 2023 at 08:19:18AM -0600, Rodrigo Siqueira wrote:
>> This commit is the last part of the fix that reduces the stack size in
>> the DML2 code.
>>
> 
> That does not really help when trying to build allmodconfig or allyesconfig
> with gcc 11.4 or 12.3.
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes
> 
> This is with v6.6-14500-g1c41041124bd.
> 
> I am overwriting it by forcing CONFIG_FRAME_WARN=0 in my test builds for
> x86_64, but of course that affects all code. Maybe consider increasing
> frame-larger-than in drivers/gpu/drm/amd/display/dc/dml2/Makefile ?

That has been done as of the following patch:
https://patchwork.freedesktop.org/patch/565675/

> Currently it is
> 
> ifneq ($(CONFIG_FRAME_WARN),0)
> frame_warn_flag := -Wframe-larger-than=2048
> endif
> 
> Guenter
-- 
Hamza



More information about the amd-gfx mailing list