[PATCH] drm/amdgpu: Address member 'ring' not described in 'amdgpu_ vce, uvd_entity_init()'

[Christian König]

Am 12.11.23 um 05:25 schrieb Srinivasan Shanmugam:
> Fixes the following:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:237: warning: Function parameter or member 'ring' not described in 'amdgpu_vce_entity_init'
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:405: warning: Function parameter or member 'ring' not described in 'amdgpu_uvd_entity_init'
>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index 65949cc7abb9..354317c9e47a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -398,6 +398,7 @@ int amdgpu_uvd_sw_fini(struct amdgpu_device *adev)
>    * amdgpu_uvd_entity_init - init entity
>    *
>    * @adev: amdgpu_device pointer
> + * @ring: UVD scheduling entity on ring

Better use something like "hardware ring the entity might want to use".

Christian.

>    *
>    * Initialize the entity used for handle management in the kernel driver.
>    */
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> index 0954447f689d..578c5c90448f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> @@ -230,6 +230,7 @@ int amdgpu_vce_sw_fini(struct amdgpu_device *adev)
>    * amdgpu_vce_entity_init - init entity
>    *
>    * @adev: amdgpu_device pointer
> + * @ring: VCE scheduling entity on ring
>    *
>    * Initialize the entity used for handle management in the kernel driver.
>    */