[PATCH] drm/amdgpu: needn't set aggregated doorbell for map queue

[Liang, Prike]

[Public]

Please ignore this patch, double confirm from the stakeholder the MES map queue has possibility to change as an unmap queue after write the doorbell.

Regards,
--Prike

> -----Original Message-----
> From: Liang, Prike <Prike.Liang at amd.com>
> Sent: Thursday, November 9, 2023 3:36 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Liang, Prike
> <Prike.Liang at amd.com>
> Subject: [PATCH] drm/amdgpu: needn't set aggregated doorbell for map
> queue
>
> Needn't set aggregated doorbell for map queue and remove the dead code.
>
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 4 ----
>  2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index c8a3bf01743f..601bb6755bd3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -8220,9 +8220,6 @@ static void gfx_v10_0_ring_set_wptr_gfx(struct
> amdgpu_ring *ring)
>                       WDOORBELL64(ring->doorbell_index, wptr_tmp);
>               } else {
>                       WDOORBELL64(ring->doorbell_index, wptr_tmp);
> -
> -                     if (*is_queue_unmap)
> -                             WDOORBELL64(aggregated_db_index,
> wptr_tmp);
>               }
>       } else {
>               if (ring->use_doorbell) {
> @@ -8283,9 +8280,6 @@ static void
> gfx_v10_0_ring_set_wptr_compute(struct amdgpu_ring *ring)
>                       WDOORBELL64(ring->doorbell_index, wptr_tmp);
>               } else {
>                       WDOORBELL64(ring->doorbell_index, wptr_tmp);
> -
> -                     if (*is_queue_unmap)
> -                             WDOORBELL64(aggregated_db_index,
> wptr_tmp);
>               }
>       } else {
>               /* XXX check if swapping is necessary on BE */ diff --git
> a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> index c1ff5eda8961..14633e2ceac6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> @@ -358,10 +358,6 @@ static void sdma_v5_0_ring_set_wptr(struct
> amdgpu_ring *ring)
>                       DRM_DEBUG("calling WDOORBELL64(0x%08x,
> 0x%016llx)\n",
>                                       ring->doorbell_index, ring->wptr <<
> 2);
>                       WDOORBELL64(ring->doorbell_index, ring->wptr <<
> 2);
> -
> -                     if (*is_queue_unmap)
> -                             WDOORBELL64(aggregated_db_index,
> -                                         ring->wptr << 2);
>               }
>       } else {
>               if (ring->use_doorbell) {
> --
> 2.34.1