[PATCH] Add function parameter 'xcc_mask' not described in 'amdgpu_vm_flush_compute_tlb'

Christian König christian.koenig at amd.com
Wed Nov 15 07:01:14 UTC 2023


Felix that looks a bit fishy to me, can you take a look?

Why are we giving the xcc_mask as parameter here? IIRC the partition a 
VM is used with is fixed because the page tables are created 
individually for each partition.

Thanks,
Christian.

Am 12.11.23 um 05:45 schrieb Srinivasan Shanmugam:
> Fixes the below:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1373: warning: Function parameter or member 'xcc_mask' not described in 'amdgpu_vm_flush_compute_tlb'
>
> Cc: Felix Kuehling <Felix.Kuehling at amd.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index be084cbe7501..cd4970c2efc5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1360,7 +1360,7 @@ int amdgpu_vm_handle_moved(struct amdgpu_device *adev,
>    * @adev: amdgpu_device pointer
>    * @vm: requested vm
>    * @flush_type: flush type
> - *
> + * @xcc_mask: mask of XCCs for the XCCs available on ASIC.
>    * Flush TLB if needed for a compute VM.
>    *
>    * Returns:



More information about the amd-gfx mailing list