[1/5] drm/amdgpu/gmc11: fix logic typo in AGP check

Mario Limonciello mario.limonciello at amd.com
Thu Nov 16 21:36:29 UTC 2023


On 11/9/2023 14:51, Alex Deucher wrote:
> Should be && rather than ||.
> 
> Fixes: b2e1cbe6281f ("drm/amdgpu/gmc11: disable AGP on GC 11.5")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---

For the series:
Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>
Tested-by: Mario Limonciello <mario.limonciello at amd.com> # PHX & Navi33

>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> index 6dce9b29f675..ba4c82f5e617 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
> @@ -640,7 +640,7 @@ static void gmc_v11_0_vram_gtt_location(struct amdgpu_device *adev,
>   	amdgpu_gmc_set_agp_default(adev, mc);
>   	amdgpu_gmc_vram_location(adev, &adev->gmc, base);
>   	amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_HIGH);
> -	if (!amdgpu_sriov_vf(adev) ||
> +	if (!amdgpu_sriov_vf(adev) &&
>   	    (amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(11, 5, 0)))
>   		amdgpu_gmc_agp_location(adev, mc);
>   



More information about the amd-gfx mailing list