[PATCH 8/8] drm/xlnx: Do not include <drm/drm_plane_helper.h>

Thomas Zimmermann tzimmermann at suse.de
Tue Nov 28 14:13:03 UTC 2023


Hi

Am 28.11.23 um 12:02 schrieb Laurent Pinchart:
> Hi Thomas,
> 
> Thank you for the patch.
> 
> On Tue, Nov 28, 2023 at 11:45:24AM +0100, Thomas Zimmermann wrote:
>> Remove unnecessary include statements for <drm/drm_plane_helper.h>.
>> The file contains helpers for non-atomic code and should not be
>> required by most drivers. No functional changes.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> 
> Assuming you've compile-tested the driver,

I've COMPILE_TEST'ed the driver on aarch64.

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> Please get this merged through drm-misc as part of the series if
> possible.

Sure.

Best regards
Thomas

> 
>> ---
>>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
>> index a7f8611be6f42..db3bb4afbfc46 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
>> @@ -27,7 +27,6 @@
>>   #include <drm/drm_managed.h>
>>   #include <drm/drm_mode_config.h>
>>   #include <drm/drm_plane.h>
>> -#include <drm/drm_plane_helper.h>
>>   #include <drm/drm_probe_helper.h>
>>   #include <drm/drm_simple_kms_helper.h>
>>   #include <drm/drm_vblank.h>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20231128/2fe3706e/attachment.sig>


More information about the amd-gfx mailing list