[PATCH 1/5] drm/amdgpu: Move package type enum to amdgpu.h

[Christian König]

Yeah, agree. Just keep it where it is actually used.

Regards,
Christian.

Am 03.10.23 um 18:56 schrieb Zhang, Hawking:
> [AMD Official Use Only - General]
>
> Alternatively, might just keep the PKG_TYPE definition in amdgpu_smuio.h
>
> Regards,
> Hawking
>
> -----Original Message-----
> From: Lazar, Lijo <Lijo.Lazar at amd.com>
> Sent: Wednesday, October 4, 2023 00:51
> To: Lazar, Lijo <Lijo.Lazar at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
> Subject: RE: [PATCH 1/5] drm/amdgpu: Move package type enum to amdgpu.h
>
> [AMD Official Use Only - General]
>
> Ping on this series.
>
> Since there is no alternate header to put device property other than amdgpu.h, this can be moved also when appropriate split of header files are decided. Other than that any comments on this?
>
> Thanks,
> Lijo
>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Lijo Lazar
> Sent: Friday, September 29, 2023 3:08 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
> Subject: [PATCH 1/5] drm/amdgpu: Move package type enum to amdgpu.h
>
> Move definition of package type to amdgpu header and add new package types for CEM and OAM.
>
> Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 7 +++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 5 -----
>   2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 73e825d20259..ac048a77e97c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -302,6 +302,13 @@ struct amdgpu_hive_info;  struct amdgpu_reset_context;  struct amdgpu_reset_control;
>
> +enum amdgpu_pkg_type {
> +       AMDGPU_PKG_TYPE_APU = 2,
> +       AMDGPU_PKG_TYPE_CEM = 3,
> +       AMDGPU_PKG_TYPE_OAM = 4,
> +       AMDGPU_PKG_TYPE_UNKNOWN,
> +};
> +
>   enum amdgpu_cp_irq {
>          AMDGPU_CP_IRQ_GFX_ME0_PIPE0_EOP = 0,
>          AMDGPU_CP_IRQ_GFX_ME0_PIPE1_EOP, diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> index 42ac6d1bf9ca..7088c5015675 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> @@ -69,11 +69,6 @@ enum amdgpu_gfx_partition {
>
>   #define NUM_XCC(x) hweight16(x)
>
> -enum amdgpu_pkg_type {
> -       AMDGPU_PKG_TYPE_APU = 2,
> -       AMDGPU_PKG_TYPE_UNKNOWN,
> -};
> -
>   enum amdgpu_gfx_ras_mem_id_type {
>          AMDGPU_GFX_CP_MEM = 0,
>          AMDGPU_GFX_GCEA_MEM,
> --
> 2.25.1
>
>