[PATCH v3 12/16] drm/amd/display: Fix Chroma Surface height/width initialization

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Wed Oct 4 21:21:06 UTC 2023


From: Sung Joon Kim <sungkim at amd.com>

[why]
Surface height/width for Chroma has another variable that it should be
intialized to, chroma_size. Fixing this will help pass DML2.0 validation
for YCbCr420 tests, DCHB006.109,129, DCHB014.011,012.

[how]
Assign SurfaceHeight/WidthC to chroma_size.height/width

Reviewed-by: Charlene Liu <charlene.liu at amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo at amd.com>
Signed-off-by: Sung Joon Kim <sungkim at amd.com>
---
 drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
index 2dd8eedfc17d..e5ccd2887c94 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
@@ -721,8 +721,8 @@ static void populate_dml_surface_cfg_from_plane_state(enum dml_project_id dml2_p
 	out->PitchY[location] = in->plane_size.surface_pitch;
 	out->SurfaceHeightY[location] = in->plane_size.surface_size.height;
 	out->SurfaceWidthY[location] = in->plane_size.surface_size.width;
-	out->SurfaceHeightC[location] = in->plane_size.surface_size.height;
-	out->SurfaceWidthC[location] = in->plane_size.surface_size.width;
+	out->SurfaceHeightC[location] = in->plane_size.chroma_size.height;
+	out->SurfaceWidthC[location] = in->plane_size.chroma_size.width;
 	out->PitchC[location] = in->plane_size.chroma_pitch;
 	out->DCCEnable[location] = in->dcc.enable;
 	out->DCCMetaPitchY[location] = in->dcc.meta_pitch;
-- 
2.40.1



More information about the amd-gfx mailing list