[PATCH Review 1/1] drm/amdgpu: Enable mca debug mode mode for apu

[Zhang, Hawking]

[AMD Official Use Only - General]

Let's not rely on specific IP block. Just check adev->ras_enabled.

Regards,
Hawking

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Stanley.Yang
Sent: Wednesday, October 18, 2023 20:22
To: amd-gfx at lists.freedesktop.org
Cc: Yang, Stanley <Stanley.Yang at amd.com>
Subject: [PATCH Review 1/1] drm/amdgpu: Enable mca debug mode mode for apu

Enable smu_v13_0_6 mca debug mode when GFX RAS feature is enabled on APU.

Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index cab5a5569bc6..62589ba3c4a5 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -2298,7 +2298,8 @@ static int smu_v13_0_6_post_init(struct smu_context *smu)  {
        struct amdgpu_device *adev = smu->adev;

-       if (!amdgpu_sriov_vf(adev) && amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC))
+       if (!amdgpu_sriov_vf(adev) && (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC) ||
+               (adev->is_app_apu && amdgpu_ras_is_supported(adev,
+AMDGPU_RAS_BLOCK__GFX))))
                return smu_v13_0_6_mca_set_debug_mode(smu, true);

        return 0;
--
2.25.1