[PATCH 03/26] drm/amd/display: Remove power sequencing check

Hamza Mahfooz hamza.mahfooz at amd.com
Wed Oct 18 18:02:06 UTC 2023


On 10/18/23 13:41, Roman.Li at amd.com wrote:
> From: Agustin Gutierrez <agustin.gutierrez at amd.com>
> 
> [Why]
> 	Some ASICs keep backlight powered on after dpms off
> 	command has been issued.
> 
> [How]
> 	The check for no edp power sequencing was never going to pass.
> 	The value is never changed from what it is set by design.
> 

Cc: stable at vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2765

> Reviewed-by: Swapnil Patel <swapnil.patel at amd.com>
> Acked-by: Roman Li <roman.li at amd.com>
> Signed-off-by: Agustin Gutierrez <agustin.gutierrez at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> index 4538451945b4..34a4a8c0e18c 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
> @@ -1932,8 +1932,7 @@ static void disable_link_dp(struct dc_link *link,
>   	dp_disable_link_phy(link, link_res, signal);
>   
>   	if (link->connector_signal == SIGNAL_TYPE_EDP) {
> -		if (!link->dc->config.edp_no_power_sequencing &&
> -			!link->skip_implict_edp_power_control)
> +		if (!link->skip_implict_edp_power_control)
>   			link->dc->hwss.edp_power_control(link, false);
>   	}
>   
-- 
Hamza



More information about the amd-gfx mailing list