[PATCH 4/4] drm/amd: Enable seamless boot by default on newer APUs

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Mario
> Limonciello
> Sent: Tuesday, September 5, 2023 3:26 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Limonciello, Mario <Mario.Limonciello at amd.com>
> Subject: [PATCH 4/4] drm/amd: Enable seamless boot by default on newer
> APUs
>
> IP discovery is a good line in the sand to expand seamless boot to more ASICs.
>
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 9159a7b993ab..19265dbe592e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1296,14 +1296,10 @@ bool amdgpu_seamless_boot_supported(struct
> amdgpu_device *adev)
>       if (adev->mman.keep_stolen_vga_memory)
>               return false;

This probably needs to be revisited too.  I don't know why this is an issue.  This flag just means the kernel driver keeps the stolen VGA region as reserved rather than releasing it back into the pool of available memory.  I don't think it should directly affect this feature.

>
> -     switch (adev->ip_versions[DCE_HWIP][0]) {
> -     case IP_VERSION(3, 0, 1):
> -             return true;
> -     default:
> -             break;
> -     }
> +     if (adev->asic_type != CHIP_IP_DISCOVERY)
> +             return false;

Probably need input from the display team, but I think a number of the older chips we'd probably want this too.  Maybe base it on the DCE_HWIP version?  DCN 1.0.0 or newer?  Or maybe  DCN 3.0.0 or newer?

>
> -     return false;
> +     return adev->flags & AMD_IS_APU;
>  }
>
>  /*
> --
> 2.34.1