[PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
Rodrigo Vivi
rodrigo.vivi at intel.com
Wed Sep 6 16:42:35 UTC 2023
On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote:
> Hi Jim,
>
> On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> > By at least strong convention, a print-buffer's trailing newline says
> > "message complete, send it". The exception (no TNL, followed by a call
> > to pr_cont) proves the general rule.
> >
> > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
> >
> > No functional changes.
> >
> > Signed-off-by: Jim Cromie <jim.cromie at gmail.com>
>
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
I pushed this i915 one to our drm-intel-next.
While doing it I have changed the subject to make it clear
this is 'drm/i915:'.
I believe you should do similar change to all the other patches
to make it clear in the subject about which domain that commit
is touching... instead of only 'drm_dbg'.
i.e.: 183670347b06 ("drm/i915: add trailing newlines to msgs")
https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=183670347b060521920a81f84ff7f10e227ebe05
Thanks for the patch,
Rodrigo.
>
> Andi
More information about the amd-gfx
mailing list