[PATCH 4/4] drm/amdgpu/gmc11: disable AGP on GC 11.5

Christian König ckoenig.leichtzumerken at gmail.com
Fri Sep 15 06:13:33 UTC 2023


Am 14.09.23 um 20:49 schrieb Alex Deucher:
> On Thu, Sep 14, 2023 at 2:31 PM Alex Deucher <alexander.deucher at amd.com> wrote:
>> AGP aperture is deprecated and no longer functional.
>>
>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>> index 6947b598e9b2..7ee91b66f761 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>> @@ -745,6 +745,9 @@ static int gmc_v11_0_mc_init(struct amdgpu_device *adev)
>>                  adev->gmc.gart_placement = AMDGPU_GART_PLACEMENT_LOW;
>>          else
>>                  adev->gmc.gart_placement = AMDGPU_GART_PLACEMENT_HIGH;
>> +       /* AGP aperture is removed on GC11.5 */
>> +       if (amdgpu_ip_version(adev, GC_HWIP, -2) >= IP_VERSION(11, 5, 0))
> Not sure what happened here.  I've replaced the -2 with 0 locally.

I also don't see patch #1 in the series.

Patch #3 shouldn't be necessary, if the AGP aperture isn't wanted the 
code should just not call amdgpu_gmc_agp_location().

Christian.

>
> Alex
>
>> +               adev->gmc.no_agp = true;
>>
>>          gmc_v11_0_vram_gtt_location(adev, &adev->gmc);
>>
>> --
>> 2.41.0
>>



More information about the amd-gfx mailing list