[PATCH] drm/amdkfd: Remove svm range validated_once flag
Felix Kuehling
felix.kuehling at amd.com
Mon Sep 18 17:52:44 UTC 2023
On 2023-09-15 16:18, Philip Yang wrote:
> The validated_once flag is not used after the prefault was removed, The
> prefault was needed to ensure validate all system memory pages at least
> once before mapping or migrating the range to GPU.
>
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 26018b1d6138..562da3c40515 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1730,9 +1730,6 @@ static int svm_range_validate_and_map(struct mm_struct *mm,
> addr = next;
> }
>
> - if (addr == end)
> - prange->validated_once = true;
> -
> unreserve_out:
> svm_range_unreserve_bos(ctx);
> if (!r)
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h b/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> index 91715bf3233c..25f711905738 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> @@ -132,7 +132,6 @@ struct svm_range {
> struct list_head child_list;
> DECLARE_BITMAP(bitmap_access, MAX_GPU_INSTANCE);
> DECLARE_BITMAP(bitmap_aip, MAX_GPU_INSTANCE);
> - bool validated_once;
> bool mapped_to_gpu;
> };
>
More information about the amd-gfx
mailing list