[PATCH] drm/amdkfd: Don't use sw fault filter if retry cam enabled

Christian König ckoenig.leichtzumerken at gmail.com
Wed Sep 20 05:56:38 UTC 2023


Am 19.09.23 um 16:09 schrieb Philip Yang:
> If retry cam enabled, we don't use sw retry fault filter and add fault
> into sw filter ring, so we shouldn't remove fault from sw filter.
>
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7793db6d098..f357d1f7353a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -452,7 +452,10 @@ void amdgpu_gmc_filter_faults_remove(struct amdgpu_device *adev, uint64_t addr,
>   	uint32_t hash;
>   	uint64_t tmp;
>   
> -	ih = adev->irq.retry_cam_enabled ? &adev->irq.ih_soft : &adev->irq.ih1;
> +	if (adev->irq.retry_cam_enabled)
> +		return;
> +
> +	ih = &adev->irq.ih1;
>   	/* Get the WPTR of the last entry in IH ring */
>   	last_wptr = amdgpu_ih_get_wptr(adev, ih);
>   	/* Order wptr with ring data. */



More information about the amd-gfx mailing list