[PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: Arnd Bergmann <arnd at kernel.org>
> Sent: Tuesday, September 26, 2023 1:49 PM
> To: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-
> gfx at lists.freedesktop.org
> Subject: Re: [PATCH 2/2] drm/amdkfd: drop struct kfd_cu_info
>
> On Tue, Sep 26, 2023, at 18:39, Alex Deucher wrote:
> > I think this was an abstraction back from when kfd supported both
> > radeon and amdgpu.  Since we just support amdgpu now, there is no more
> > need for this and we can use the amdgpu structures directly.
> >
> > This also avoids having the kfd_cu_info structures on the stack when
> > inlining which can blow up the stack.
> >
> > Cc: Arnd Bergmann <arnd at kernel.org>
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>
> Nice cleanup!
>
> Acked-by: Arnd Bergmann <arnd at arndb.de>
>
> I guess you could fold patch 1/2 into this as it removes all the added code from
> that anyway.

I left it as a separate patch as I didn't get a chance to see when the stack warning appeared and figured it might be a good way to mitigate that on stable kernels if necessary without pulling in the whole rework, but if not, I can just squash it into the second patch.

Alex