[PATCH] drm/amd/pm: delete dead code

Alex Deucher alexdeucher at gmail.com
Thu Sep 28 02:24:41 UTC 2023


Applied.  Thanks!

Alex

On Wed, Sep 27, 2023 at 2:57 PM Wang, Yang(Kevin)
<KevinYang.Wang at amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Thanks.
>
> Reviewed-by: Yang Wang <kevinyang.wang at amd.com>
>
> Best Regards,
> Kevin
>
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter at linaro.org>
> Sent: Wednesday, September 27, 2023 8:38 PM
> To: Evan Quan <evan.quan at amd.com>; Wang, Yang(Kevin) <KevinYang.Wang at amd.com>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Pan, Xinhui <Xinhui.Pan at amd.com>; David Airlie <airlied at gmail.com>; Daniel Vetter <daniel at ffwll.ch>; Lazar, Lijo <Lijo.Lazar at amd.com>; Kamal, Asad <Asad.Kamal at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>; Wang, Yang(Kevin) <KevinYang.Wang at amd.com>; amd-gfx at lists.freedesktop.org; kernel-janitors at vger.kernel.org
> Subject: [PATCH] drm/amd/pm: delete dead code
>
> "ret" was checked earlier inside the loop, so we know it is zero here.
> No need to check a second time.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 11a6cd96c601..0ffe55e713f3 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -2346,9 +2346,6 @@ static int mca_get_mca_entry(struct amdgpu_device *adev, enum amdgpu_mca_error_t
>                         return ret;
>         }
>
> -       if (ret)
> -               return ret;
> -
>         entry->idx = idx;
>         entry->type = type;
>
> --
> 2.39.2
>


More information about the amd-gfx mailing list