[PATCH 1/5] drm/amdgpu: Move package type enum to amdgpu.h

[Lazar, Lijo]

On 9/29/2023 3:56 PM, Christian König wrote:
> Am 29.09.23 um 11:37 schrieb Lijo Lazar:
>> Move definition of package type to amdgpu header and add new package
>> types for CEM and OAM.
> 
> Please don't move anything to amdgpu.h that header is in the process of 
> being deprecated.
> 
> What are CEM and OAM good for here?
> 

Is there a new header to keep device/SOC property enums?

Thanks,
Lijo

> Regards,
> Christian.
> 
>>
>> Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 7 +++++++
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 5 -----
>>   2 files changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> index 73e825d20259..ac048a77e97c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
>> @@ -302,6 +302,13 @@ struct amdgpu_hive_info;
>>   struct amdgpu_reset_context;
>>   struct amdgpu_reset_control;
>> +enum amdgpu_pkg_type {
>> +    AMDGPU_PKG_TYPE_APU = 2,
>> +    AMDGPU_PKG_TYPE_CEM = 3,
>> +    AMDGPU_PKG_TYPE_OAM = 4,
>> +    AMDGPU_PKG_TYPE_UNKNOWN,
>> +};
>> +
>>   enum amdgpu_cp_irq {
>>       AMDGPU_CP_IRQ_GFX_ME0_PIPE0_EOP = 0,
>>       AMDGPU_CP_IRQ_GFX_ME0_PIPE1_EOP,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> index 42ac6d1bf9ca..7088c5015675 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
>> @@ -69,11 +69,6 @@ enum amdgpu_gfx_partition {
>>   #define NUM_XCC(x) hweight16(x)
>> -enum amdgpu_pkg_type {
>> -    AMDGPU_PKG_TYPE_APU = 2,
>> -    AMDGPU_PKG_TYPE_UNKNOWN,
>> -};
>> -
>>   enum amdgpu_gfx_ras_mem_id_type {
>>       AMDGPU_GFX_CP_MEM = 0,
>>       AMDGPU_GFX_GCEA_MEM,
>