[PATCH] drm/amdgpu: always force full reset for SOC21

Christian König ckoenig.leichtzumerken at gmail.com
Tue Apr 2 08:21:29 UTC 2024


Am 24.03.24 um 01:52 schrieb Alex Deucher:
> There are cases where soft reset seems to succeed, but
> does not, so always use mode1/2 for now.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Acked-by: Christian König <christian.koenig at amd.com>

IIRC I've requested some changes to how soft reset is done for SOC21 but 
never found the time to actually go over the new specification.

We should probably just need to adjust the soft recovery code for those 
new hardware generations.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/soc21.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c
> index 581a3bd11481..8526282f4da1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc21.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc21.c
> @@ -457,10 +457,8 @@ static bool soc21_need_full_reset(struct amdgpu_device *adev)
>   {
>   	switch (amdgpu_ip_version(adev, GC_HWIP, 0)) {
>   	case IP_VERSION(11, 0, 0):
> -		return amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC);
>   	case IP_VERSION(11, 0, 2):
>   	case IP_VERSION(11, 0, 3):
> -		return false;
>   	default:
>   		return true;
>   	}



More information about the amd-gfx mailing list