[PATCH] drm/amd/display: Add missing parameter desc in dc_commit_streams

Chung, ChiaHsuan (Tom) chiahsuan.chung at amd.com
Wed Apr 3 08:00:26 UTC 2024


Reviewed-by: Tom Chung <chiahsuan.chung at amd.com>

On 4/1/2024 9:50 PM, Srinivasan Shanmugam wrote:
> This commit removes the lines that describe the 'streams'
> and 'stream_count' parameters and adds a line to describe the 'params'
> parameter, which was missing from the original comment block.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2138: warning: Function parameter or member 'params' not described in 'dc_commit_streams'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2138: warning: Excess function parameter 'streams' description in 'dc_commit_streams'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2138: warning: Excess function parameter 'stream_count' description in 'dc_commit_streams'
>
> Fixes: 515023b2ce5f ("drm/amd/display: Add handling for DC power mode")
> Cc: Joshua Aberback <joshua.aberback at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 5a93278fa246..0ffa79d83bc7 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -2125,8 +2125,7 @@ static bool commit_minimal_transition_state(struct dc *dc,
>    * dc_commit_streams - Commit current stream state
>    *
>    * @dc: DC object with the commit state to be configured in the hardware
> - * @streams: Array with a list of stream state
> - * @stream_count: Total of streams
> + * @params: Parameters for the commit, including the streams to be committed
>    *
>    * Function responsible for commit streams change to the hardware.
>    *


More information about the amd-gfx mailing list