[PATCH V2] drm/ttm: remove unused paramter

Christian König christian.koenig at amd.com
Thu Apr 11 11:18:28 UTC 2024


Am 01.04.24 um 05:04 schrieb jesse.zhang at amd.com:
> From: Jesse Zhang <jesse.zhang at amd.com>
>
> remove the unsed the paramter in the function
> ttm_bo_bounce_temp_buffer and ttm_bo_add_move_fence.
>   V2:rebase the patch on top of drm-misc-next (Christian)

And pushed to drm-misc-next.

Thanks,
Christian.

>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index e059b1e1b13b..6396dece0db1 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -402,7 +402,6 @@ void ttm_bo_put(struct ttm_buffer_object *bo)
>   EXPORT_SYMBOL(ttm_bo_put);
>   
>   static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,
> -				     struct ttm_resource **mem,
>   				     struct ttm_operation_ctx *ctx,
>   				     struct ttm_place *hop)
>   {
> @@ -469,7 +468,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,
>   		if (ret != -EMULTIHOP)
>   			break;
>   
> -		ret = ttm_bo_bounce_temp_buffer(bo, &evict_mem, ctx, &hop);
> +		ret = ttm_bo_bounce_temp_buffer(bo, ctx, &hop);
>   	} while (!ret);
>   
>   	if (ret) {
> @@ -698,7 +697,6 @@ EXPORT_SYMBOL(ttm_bo_unpin);
>    */
>   static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
>   				 struct ttm_resource_manager *man,
> -				 struct ttm_resource *mem,
>   				 bool no_wait_gpu)
>   {
>   	struct dma_fence *fence;
> @@ -787,7 +785,7 @@ static int ttm_bo_alloc_resource(struct ttm_buffer_object *bo,
>   		if (ret)
>   			continue;
>   
> -		ret = ttm_bo_add_move_fence(bo, man, *res, ctx->no_wait_gpu);
> +		ret = ttm_bo_add_move_fence(bo, man, ctx->no_wait_gpu);
>   		if (unlikely(ret)) {
>   			ttm_resource_free(bo, res);
>   			if (ret == -EBUSY)
> @@ -894,7 +892,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,
>   bounce:
>   		ret = ttm_bo_handle_move_mem(bo, res, false, ctx, &hop);
>   		if (ret == -EMULTIHOP) {
> -			ret = ttm_bo_bounce_temp_buffer(bo, &res, ctx, &hop);
> +			ret = ttm_bo_bounce_temp_buffer(bo, ctx, &hop);
>   			/* try and move to final place now. */
>   			if (!ret)
>   				goto bounce;



More information about the amd-gfx mailing list