[PATCH] Revert "drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled"

Melissa Wen mwen at igalia.com
Thu Apr 11 22:13:27 UTC 2024


On 04/11, Rodrigo Siqueira wrote:
> This reverts commit 5aba567a2988400d4e01d44493c84bed92820d8d.
> 
> The original patch introduces cursor gamma issue to multiple
> Linux compositors. For this reason this commit reverts this change.

Thanks for checking the issue.

Reviewed-by: Melissa Wen <mwen at igalia.com>

> 
> Cc: Melissa Wen <mwen at igalia.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> index ed1e2f65f5b5..f8c0cee34080 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> @@ -395,7 +395,9 @@ void dpp3_set_cursor_attributes(
>  
>  	if (color_format == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
>  		color_format == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA) {
> -		cur_rom_en = 1;
> +		if (cursor_attributes->attribute_flags.bits.ENABLE_CURSOR_DEGAMMA) {
> +			cur_rom_en = 1;
> +		}
>  	}
>  
>  	REG_UPDATE_3(CURSOR0_CONTROL,
> -- 
> 2.43.0
> 


More information about the amd-gfx mailing list