[PATCH 02/25] drm/amd/display: Add a function for checking tmds mode

[Melissa Wen]

On 10/04/2024 18:25, Rodrigo Siqueira wrote:
> From: Chris Park <chris.park at amd.com>
>
> [Why]
> DVI is TMDS signal like HDMI but without audio.  Current signal check
> does not correctly reflect DVI clock programming.
>
> [How]
> Define a new signal check for TMDS that includes DVI to HDMI TMDS
> programming.
>
> Reviewed-by: Dillon Varone <dillon.varone at amd.com>
> Acked-by: Rodrigo Siqueira <rodrigo.siqueira at amd.com>
> Signed-off-by: Chris Park <chris.park at amd.com>
> ---
>   drivers/gpu/drm/amd/display/include/signal_types.h | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/include/signal_types.h b/drivers/gpu/drm/amd/display/include/signal_types.h
> index 1b14b17a79c7..a10d6b988aab 100644
> --- a/drivers/gpu/drm/amd/display/include/signal_types.h
> +++ b/drivers/gpu/drm/amd/display/include/signal_types.h
> @@ -118,6 +118,19 @@ static inline bool dc_is_dvi_signal(enum signal_type signal)
>   	}
>   }
>   
> +static inline bool dc_is_tmds_signal(enum signal_type signal)
> +{
> +	switch (signal) {
> +	case SIGNAL_TYPE_DVI_SINGLE_LINK:
> +	case SIGNAL_TYPE_DVI_DUAL_LINK:
> +	case SIGNAL_TYPE_HDMI_TYPE_A:
> +		return true;
> +	break;
> +	default:
> +		return false;
> +	}
> +}
> +
>   static inline bool dc_is_dvi_single_link_signal(enum signal_type signal)
>   {
>   	return (signal == SIGNAL_TYPE_DVI_SINGLE_LINK);
Is this patch complete? It creates a helper that isn't used anywhere (?)

BR,

Melissa