[PATCH] drm/amdgpu: Fix two reset triggered in a row

Felix Kuehling felix.kuehling at amd.com
Tue Apr 23 02:01:56 UTC 2024


On 2024-04-22 16:14, Alex Deucher wrote:
> On Mon, Apr 22, 2024 at 3:52 PM Yunxiang Li <Yunxiang.Li at amd.com> wrote:
>> Reset request from KFD is missing a check for if a reset is already in
>> progress, this causes a second reset to be triggered right after the
>> previous one finishes. Add the check to align with the other reset sources.
> Acked-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Felix Kuehling <felix.kuehling at amd.com>


>
>> Signed-off-by: Yunxiang Li <Yunxiang.Li at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> index 3b4591f554f1..ce3dbb1cc2da 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> @@ -283,7 +283,7 @@ int amdgpu_amdkfd_post_reset(struct amdgpu_device *adev)
>>
>>   void amdgpu_amdkfd_gpu_reset(struct amdgpu_device *adev)
>>   {
>> -       if (amdgpu_device_should_recover_gpu(adev))
>> +       if (amdgpu_device_should_recover_gpu(adev) && !amdgpu_in_reset(adev))
>>                  amdgpu_reset_domain_schedule(adev->reset_domain,
>>                                               &adev->kfd.reset_work);
>>   }
>> --
>> 2.34.1
>>


More information about the amd-gfx mailing list