[PATCH] drm/amd/display: Address kdoc for 'Enable CRTC' in optc401_enable_crtc

Chung, ChiaHsuan (Tom) chiahsuan.chung at amd.com
Tue Apr 23 03:21:53 UTC 2024


Reviewed-by: Tom Chung <chiahsuan.chung at amd.com>

On 4/23/2024 9:59 AM, Srinivasan Shanmugam wrote:
> This commit fixes the kdoc for 'Enable CRTC' in `optc401_enable_crtc`
> function.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn401/dcn401_optc.c:177: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>   * Enable CRTC
>
> Fixes: 96c23c8cb3fb ("drm/amd/display: Add new DCN401 sources")
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Qingqing Zhuo <Qingqing.Zhuo at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c
> index 3c7b0624acea..5d65d8376f50 100644
> --- a/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c
> @@ -174,8 +174,12 @@ static void optc401_set_h_timing_div_manual_mode(struct timing_generator *optc,
>   			OTG_H_TIMING_DIV_MODE_MANUAL, manual_mode ? 1 : 0);
>   }
>   /**
> - * Enable CRTC
> - * Enable CRTC - call ASIC Control Object to enable Timing generator.
> + * optc401_enable_crtc() - Enable CRTC
> + * @optc: Pointer to the timing generator structure
> + *
> + * This function calls ASIC Control Object to enable Timing generator.
> + *
> + * Return: Always returns true
>    */
>   static bool optc401_enable_crtc(struct timing_generator *optc)
>   {


More information about the amd-gfx mailing list