[PATCH 4/4] drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc

Christian König christian.koenig at amd.com
Wed Apr 24 08:15:01 UTC 2024


Am 24.04.24 um 04:50 schrieb jesse.zhang at amd.com:
> From: Jesse Zhang <jesse.zhang at amd.com>
>
> Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>

To really improve the handling we would actually need to have a separate 
value of 0xffffffff.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> index 59acf424a078..60d97cd14855 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> @@ -742,7 +742,7 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p,
>   	uint32_t destroyed = 0;
>   	uint32_t created = 0;
>   	uint32_t allocated = 0;
> -	uint32_t tmp, handle = 0;
> +	uint32_t tmp = 0, handle = 0;
>   	uint32_t *size = &tmp;
>   	unsigned int idx;
>   	int i, r = 0;



More information about the amd-gfx mailing list