[PATCH 4/4 V2] drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc
Christian König
christian.koenig at amd.com
Wed Apr 24 09:05:41 UTC 2024
Am 24.04.24 um 11:04 schrieb Jesse Zhang:
> Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
> V2: To really improve the handling we would actually
> need to have a separate value of 0xffffffff.(Christian)
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> Suggested-by: Christian König <christian.koenig at amd.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> index 59acf424a078..968ca2c84ef7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> @@ -743,7 +743,8 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p,
> uint32_t created = 0;
> uint32_t allocated = 0;
> uint32_t tmp, handle = 0;
> - uint32_t *size = &tmp;
> + uint32_t dummy = 0xffffffff;
> + uint32_t *size = &dummy;
> unsigned int idx;
> int i, r = 0;
>
More information about the amd-gfx
mailing list