[PATCH] drm/amdgpu: fix potential resource leak warning
Christian König
christian.koenig at amd.com
Thu Apr 25 06:42:16 UTC 2024
Am 25.04.24 um 05:33 schrieb Tim Huang:
> From: Tim Huang <Tim.Huang at amd.com>
>
> Clear resource leak warning that when the prepare fails,
> the allocated amdgpu job object will never be released.
>
> Signed-off-by: Tim Huang <Tim.Huang at amd.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> index 66e8a016126b..9b748d7058b5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
> @@ -102,6 +102,11 @@ static int amdgpu_vm_sdma_prepare(struct amdgpu_vm_update_params *p,
> if (!r)
> r = amdgpu_sync_push_to_job(&sync, p->job);
> amdgpu_sync_free(&sync);
> +
> + if (r) {
> + p->num_dw_left = 0;
> + amdgpu_job_free(p->job);
> + }
> return r;
> }
>
More information about the amd-gfx
mailing list