[PATCH] drm/amdgpu: fix the warning about the expression (int)size - len
Alex Deucher
alexdeucher at gmail.com
Thu Apr 25 13:29:45 UTC 2024
On Thu, Apr 25, 2024 at 3:37 AM Jesse Zhang <jesse.zhang at amd.com> wrote:
>
> Converting size from size_t to int may overflow.
> v2: keep reverse xmas tree order (Christian)
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index f5d0fa207a88..b62ae3c91a9d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
> struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
> char reg_offset[11];
> uint32_t *new = NULL, *tmp = NULL;
> - int ret, i = 0, len = 0;
> + unsigned int len = 0;
> + int ret, i = 0;
>
> do {
> memset(reg_offset, 0, 11);
> if (copy_from_user(reg_offset, buf + len,
> - min(10, ((int)size-len)))) {
> + min(10, (size-len)))) {
> ret = -EFAULT;
> goto error_free;
> }
> --
> 2.25.1
>
More information about the amd-gfx
mailing list