[PATCH] drm/amd/display: Disable panel replay by default for now

[Harry Wentland]

On 2024-04-30 11:12, Mario Limonciello wrote:
> Panel replay was enabled by default in commit 5950efe25ee0
> ("drm/amd/display: Enable Panel Replay for static screen use case"), but
> it isn't working properly at least on some BOE and AUO panels.  Instead
> of being static the screen is solid black when active.  As it's a new
> feature that was just introduced that regressed VRR disable it for now
> so that problem can be properly root caused.
> 
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344
> Fixes: 5950efe25ee0 ("drm/amd/display: Enable Panel Replay for static screen use case")
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>

Acked-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 +++++++++++--------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8245cc63712f..b5e5cbbe5e49 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4581,15 +4581,18 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
>  	/* Determine whether to enable Replay support by default. */
>  	if (!(amdgpu_dc_debug_mask & DC_DISABLE_REPLAY)) {
>  		switch (amdgpu_ip_version(adev, DCE_HWIP, 0)) {
> -		case IP_VERSION(3, 1, 4):
> -		case IP_VERSION(3, 1, 5):
> -		case IP_VERSION(3, 1, 6):
> -		case IP_VERSION(3, 2, 0):
> -		case IP_VERSION(3, 2, 1):
> -		case IP_VERSION(3, 5, 0):
> -		case IP_VERSION(3, 5, 1):
> -			replay_feature_enabled = true;
> -			break;
> +/*
> + * Disabled by default due to https://gitlab.freedesktop.org/drm/amd/-/issues/3344
> + *		case IP_VERSION(3, 1, 4):
> + *		case IP_VERSION(3, 1, 5):
> + *		case IP_VERSION(3, 1, 6):
> + *		case IP_VERSION(3, 2, 0):
> + *		case IP_VERSION(3, 2, 1):
> + *		case IP_VERSION(3, 5, 0):
> + *		case IP_VERSION(3, 5, 1):
> + *			replay_feature_enabled = true;
> + *			break;
> + */
>  		default:
>  			replay_feature_enabled = amdgpu_dc_feature_mask & DC_REPLAY_MASK;
>  			break;