[PATCH] drm/amd/display: Remove redundant NULL check in dce110_set_input_transfer_func

[Aurabindo Pillai]

Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>

On 4/23/24 9:29 PM, Srinivasan Shanmugam wrote:
> This commit removes a redundant NULL check in the
> `dce110_set_input_transfer_func` function in the `dce110_hwseq.c` file.
> The variable `tf` is assigned the address of
> `plane_state->in_transfer_func` unconditionally, so it can never be
> `NULL`. Therefore, the check `if (tf == NULL)` is unnecessary and has
> been removed.
> 
> Fixes the below smatch warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dce110/dce110_hwseq.c:301 dce110_set_input_transfer_func() warn: address of 'plane_state->in_transfer_func' is non-NULL
> 
> Fixes: 285a7054bf81 ("drm/amd/display: Remove plane and stream pointers from dc scratch")
> Cc: Wenjing Liu <wenjing.liu at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Cc: Alvin Lee <alvin.lee2 at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Hersen Wu <hersenxs.wu at amd.com>
> Cc: Alex Hung <alex.hung at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Suggested-by: Dan Carpenter <dan.carpenter at linaro.org>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
> index 5920d1825a4c..8e50a5432d33 100644
> --- a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
> @@ -298,10 +298,7 @@ dce110_set_input_transfer_func(struct dc *dc, struct pipe_ctx *pipe_ctx,
>   			dce_use_lut(plane_state->format))
>   		ipp->funcs->ipp_program_input_lut(ipp, &plane_state->gamma_correction);
>   
> -	if (tf == NULL) {
> -		/* Default case if no input transfer function specified */
> -		ipp->funcs->ipp_set_degamma(ipp, IPP_DEGAMMA_MODE_HW_sRGB);
> -	} else if (tf->type == TF_TYPE_PREDEFINED) {
> +	if (tf->type == TF_TYPE_PREDEFINED) {
>   		switch (tf->tf) {
>   		case TRANSFER_FUNCTION_SRGB:
>   			ipp->funcs->ipp_set_degamma(ipp, IPP_DEGAMMA_MODE_HW_sRGB);

-- 
--

Thanks & Regards,
Aurabindo Pillai