[PATCH] drm/amd/display: Align hwss_wait_for_all_blank_complete descriptor with implementation

Chung, ChiaHsuan (Tom) chiahsuan.chung at amd.com
Tue Aug 13 06:05:36 UTC 2024


Reviewed-by: Tom Chung <chiahsuan.chung at amd.com>

On 8/12/2024 6:40 PM, Srinivasan Shanmugam wrote:
> The descriptor for `hwss_wait_for_all_blank_complete` was previously
> misaligned with the actual implementation. This commit refines the
> descriptor to reflect the implementation of
> `hwss_wait_for_all_blank_complete`
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:991: warning: expecting prototype for hwss_wait_for_blank_complete(). Prototype was for hwss_wait_for_all_blank_complete() instead
>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Alex Hung <alex.hung at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Hamza Mahfooz <hamza.mahfooz at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> index 9a569aac3c00..7ee2be8f82c4 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> @@ -980,7 +980,7 @@ void get_surface_tile_visual_confirm_color(
>   }
>   
>   /**
> - * hwss_wait_for_blank_complete - wait for all active OPPs to finish pending blank
> + * hwss_wait_for_all_blank_complete - wait for all active OPPs to finish pending blank
>    * pattern updates
>    *
>    * @dc: [in] dc reference


More information about the amd-gfx mailing list