[PATCH 9/9] drm/tilcdc: Use backlight power constants

Thomas Zimmermann tzimmermann at suse.de
Thu Aug 15 08:08:50 UTC 2024



Am 15.08.24 um 10:07 schrieb Tomi Valkeinen:
> Hi,
>
> On 15/08/2024 10:59, Thomas Zimmermann wrote:
>> Ping. This patch still needs an ack.
>>
>> Am 31.07.24 um 14:17 schrieb Thomas Zimmermann:
>>> Replace FB_BLANK_ constants with their counterparts from the
>>> backlight subsystem. The values are identical, so there's no
>>> change in functionality or semantics.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>>> Cc: Jyri Sarha <jyri.sarha at iki.fi>
>>> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>>> ---
>>>   drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c 
>>> b/drivers/gpu/drm/ tilcdc/tilcdc_panel.c
>>> index 68093d6b6b16..5f2d1b6f9ee9 100644
>>> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
>>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
>>> @@ -49,7 +49,7 @@ static void panel_encoder_dpms(struct drm_encoder 
>>> *encoder, int mode)
>>>       if (backlight) {
>>>           backlight->props.power = mode == DRM_MODE_DPMS_ON ?
>>> -                     FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;
>>> +                     BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF;
>>>           backlight_update_status(backlight);
>>>       }
>>
>
> Jyri acked it a few weeks ago. But in addition:

Oh, I didn't see that. Sorry.

>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

Thanks

Best regards
Thomas

>
>  Tomi
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)



More information about the amd-gfx mailing list