[PATCH] drm/amdgpu: Move the dumping log out of for loop

[Huang, Trigger]

[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: Trigger Huang <Trigger.Huang at amd.com>

> -----Original Message-----
> From: Sunil Khatri <sunil.khatri at amd.com>
> Sent: Wednesday, August 28, 2024 4:09 PM
> To: Deucher, Alexander <Alexander.Deucher at amd.com>; Huang, Trigger
> <Trigger.Huang at amd.com>
> Cc: amd-gfx at lists.freedesktop.org; Khatri, Sunil <Sunil.Khatri at amd.com>
> Subject: [PATCH] drm/amdgpu: Move the dumping log out of for loop
>
> log message "Dumping IP State Completed" needs to be logged only once
> when state dumping is complete.
>
> Hence moving it out of the for loop.
>
> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 3000a49b3e5c..381c886298bf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -39,12 +39,11 @@ static void amdgpu_job_do_core_dump(struct
> amdgpu_device *adev,
>       int i;
>
>       dev_info(adev->dev, "Dumping IP State\n");
> -     for (i = 0; i < adev->num_ip_blocks; i++) {
> +     for (i = 0; i < adev->num_ip_blocks; i++)
>               if (adev->ip_blocks[i].version->funcs->dump_ip_state)
>                       adev->ip_blocks[i].version->funcs
>                               ->dump_ip_state((void *)adev);
> -             dev_info(adev->dev, "Dumping IP State Completed\n");
> -     }
> +     dev_info(adev->dev, "Dumping IP State Completed\n");
>
>       amdgpu_coredump(adev, true, false, job);  }
> --
> 2.34.1