[PATCH -next -v2 3/3] drm/nouveau/volt: use clamp() in nvkm_volt_map()

Li Zetao lizetao1 at huawei.com
Sat Aug 31 01:28:03 UTC 2024


When it needs to get a value within a certain interval, using clamp()
makes the code easier to understand than min(max()).

Reviewed-by: Lyude Paul <lyude at redhat.com>
Signed-off-by: Li Zetao <lizetao1 at huawei.com>
---
v1 -> v2: Change the patch title prefix to drm/nouveau/volt
v1: https://lore.kernel.org/all/20240830012216.603623-4-lizetao1@huawei.com/

 drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
index a17a6dd8d3de..803b98df4858 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
@@ -142,7 +142,7 @@ nvkm_volt_map(struct nvkm_volt *volt, u8 id, u8 temp)
 			return -ENODEV;
 		}
 
-		result = min(max(result, (s64)info.min), (s64)info.max);
+		result = clamp(result, (s64)info.min, (s64)info.max);
 
 		if (info.link != 0xff) {
 			int ret = nvkm_volt_map(volt, info.link, temp);
-- 
2.34.1



More information about the amd-gfx mailing list