[PATCH V4 0/6] Add panic support for all DCE/DCN

[Jocelyn Falempe]

On 09/12/2024 22:51, Harry Wentland wrote:
> Looks good now.
> 
> Series is
> Reviewed-by: Harry Wentland <harry.wentland at amd.com>
> 
> Haven't followed the whole panic support closely. Is there a
> way to trigger a panic for testing, or is there any other
> recommended way to test this?

The easiest way is to trigger a kernel panic with:
echo c > /proc/sysrq-trigger

You can also enable CONFIG_DRM_PANIC_DEBUG and echo 1 > 
/sys/kernel/debug/dri/0/drm_panic_plane_0

But as it overwrite ones of the two framebuffer, it causes flickers, and 
a few graphic artefacts, but make it somewhat easier to test, as it 
doesn't crash the machine.

Best regards,

-- 

Jocelyn




> 
> Harry
> 
> On 2024-12-09 12:00, Alex Deucher wrote:
>> + Harry
>>
>> Ping on this series.
>>
>> On Tue, Nov 12, 2024 at 4:37 PM Alex Deucher <alexander.deucher at amd.com> wrote:
>>>
>>> This builds on the patches from Lu and Jocelyn to fill in
>>> panic support for all DCE/DCN variants and code pathes.
>>>
>>> v2: refactor to provide cleaner history and share more
>>> code to provide a more consistent experience across
>>> DC and non-DC.
>>>
>>> v3: resend with the missing first patch
>>>
>>> v4: move hubp and mi code into a dc helper function
>>>
>>> Alex Deucher (5):
>>>    drm/amdgpu: add generic display panic helper code
>>>    drm/amd/display: add clear_tiling hubp callbacks
>>>    drm/amd/display: add clear_tiling mi callbacks
>>>    drm/amd/display/dc: add helper for panic updates
>>>    drm/amd/display: add non-DC drm_panic support
>>>
>>> Jocelyn Falempe (1):
>>>    drm/amd/display: add DC drm_panic support
>>>
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   | 80 +++++++++++++++++++
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.h   |  5 ++
>>>   drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        | 27 +++++++
>>>   drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        | 27 +++++++
>>>   drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         | 27 +++++++
>>>   drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         | 26 ++++++
>>>   .../amd/display/amdgpu_dm/amdgpu_dm_plane.c   | 30 ++++++-
>>>   .../gpu/drm/amd/display/dc/core/dc_surface.c  | 46 +++++++++++
>>>   drivers/gpu/drm/amd/display/dc/dc_plane.h     |  3 +
>>>   .../drm/amd/display/dc/dce/dce_mem_input.c    | 34 ++++++--
>>>   .../amd/display/dc/hubp/dcn10/dcn10_hubp.c    | 15 ++++
>>>   .../amd/display/dc/hubp/dcn10/dcn10_hubp.h    |  2 +
>>>   .../amd/display/dc/hubp/dcn20/dcn20_hubp.c    | 15 ++++
>>>   .../amd/display/dc/hubp/dcn20/dcn20_hubp.h    |  2 +
>>>   .../amd/display/dc/hubp/dcn201/dcn201_hubp.c  |  1 +
>>>   .../amd/display/dc/hubp/dcn21/dcn21_hubp.c    |  1 +
>>>   .../amd/display/dc/hubp/dcn30/dcn30_hubp.c    | 17 ++++
>>>   .../amd/display/dc/hubp/dcn30/dcn30_hubp.h    |  2 +
>>>   .../amd/display/dc/hubp/dcn31/dcn31_hubp.c    |  1 +
>>>   .../amd/display/dc/hubp/dcn32/dcn32_hubp.c    |  3 +-
>>>   .../amd/display/dc/hubp/dcn35/dcn35_hubp.c    |  1 +
>>>   .../amd/display/dc/hubp/dcn401/dcn401_hubp.c  | 15 +++-
>>>   .../amd/display/dc/hubp/dcn401/dcn401_hubp.h  |  2 +
>>>   drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h  |  1 +
>>>   .../gpu/drm/amd/display/dc/inc/hw/mem_input.h |  2 +
>>>   25 files changed, 377 insertions(+), 8 deletions(-)
>>>
>>> --
>>> 2.47.0
>>>
>