[PATCH 2/2] drm/amdgpu: add sysfs reset mask for vcn 5.0.1

David Wu davidwu2 at amd.com
Tue Dec 10 20:22:49 UTC 2024


Series is:
Reviewed-by: David (Ming Qiang) Wu <David.Wu3 at amd.com>

one thing I would like to do:
return amdgpu_vcn_sysfs_reset_mask_init(adev);

On 2024-12-10 15:03, Alex Deucher wrote:
> Add the calls to the vcn 5.0.1 code.
>
> Signed-off-by: Alex Deucher<alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
> index a076ffb3867ac..8a50dcd64e6eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
> @@ -119,8 +119,16 @@ static int vcn_v5_0_1_sw_init(struct amdgpu_ip_block *ip_block)
>   			amdgpu_vcn_fwlog_init(&adev->vcn.inst[i]);
>   	}
>   
> +	/* TODO: Add queue reset mask when FW fully supports it */
> +	adev->vcn.supported_reset =
> +		amdgpu_get_soft_full_reset_mask(&adev->vcn.inst[0].ring_enc[0]);
> +
>   	vcn_v5_0_0_alloc_ip_dump(adev);
>   
> +	r = amdgpu_vcn_sysfs_reset_mask_init(adev);
> +	if (r)
> +		return r;
> +
>   	return 0;
>   }
>   
> @@ -154,6 +162,8 @@ static int vcn_v5_0_1_sw_fini(struct amdgpu_ip_block *ip_block)
>   
>   	r = amdgpu_vcn_sw_fini(adev);
>   
> +	amdgpu_vcn_sysfs_reset_mask_fini(adev);
> +
>   	kfree(adev->vcn.ip_dump);
>   
>   	return r;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20241210/a2f458af/attachment-0001.htm>


More information about the amd-gfx mailing list