[PATCH 10/34] drm/amd/display: Add debug prints for IPS testing

[Hung, Alex]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Guenter,

Thanks for the updates.

This may be a real issue. Please file a bug at https://gitlab.freedesktop.org/drm/amd/-/issues and share your setup. This helps us investigate further.


________________________________
From: Guenter Roeck <groeck7 at gmail.com> on behalf of Guenter Roeck <linux at roeck-us.net>
Sent: 10 December 2024 20:17
To: Hung, Alex <Alex.Hung at amd.com>
Cc: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; Wentland, Harry <Harry.Wentland at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Li, Roman <Roman.Li at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung at amd.com>; hersenxs.wu at amd.com <hersenxs.wu at amd.com>; Zuo, Jerry <Jerry.Zuo at amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas at amd.com>; Ma, Duncan <Duncan.Ma at amd.com>
Subject: Re: [PATCH 10/34] drm/amd/display: Add debug prints for IPS testing

Hi,

On Wed, Feb 28, 2024 at 11:39:16AM -0700, Alex Hung wrote:
> From: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
>
> [WHY]
> To log commit states and when we transition in/out of allow and idle
> states and the caller.
>
> [HOW]
> Add a new logging helper and wrap idle optimization calls to receive
> the caller.
>
> Reviewed-by: Duncan Ma <duncan.ma at amd.com>
> Acked-by: Alex Hung <alex.hung at amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> ---
...
>
> +     DC_LOG_ERROR("%s: DMCUB error - collecting diagnostic data\n", __func__);
> +

This patch generates _lots_ of logging noise.

[689208.336969] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689219.628141] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689221.098993] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689222.645994] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689225.341470] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689226.467388] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689226.716755] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689231.507746] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689247.287990] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data
[689252.441150] amdgpu 0000:03:00.0: [drm] *ERROR* dc_dmub_srv_log_diagnostic_data: DMCUB error - collecting diagnostic data

I disabled it in my private kernel build, so no problem for me. However,
searching for the string on the web shows lots of complaints. Not my call
to make, but claiming that this patch adds "debug prints for IPS testing"
seems to be a bit misleading.

Guenter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20241211/60575806/attachment-0001.htm>